🟡 Medium vcs/GitVcsDriverCore.ts:239

parsePorcelainWorktreePaths splits the porcelain output on \n and trims each path, so worktree paths containing a newline or trailing whitespace are parsed incorrectly. For such a worktree, the registration check fails and the filesystem pre-delete is skipped, causing removal to fall back to the slow git worktree remove path this PR is meant to avoid. Git documents that worktree list --porcelain -z must be used to correctly parse paths containing newlines. Consider switching to the -z (NUL-delimited) format and splitting on \0 instead.

In file @apps/server/src/vcs/GitVcsDriverCore.ts around line 239:

`parsePorcelainWorktreePaths` splits the porcelain output on `\n` and trims each path, so worktree paths containing a newline or trailing whitespace are parsed incorrectly. For such a worktree, the registration check fails and the filesystem pre-delete is skipped, causing removal to fall back to the slow `git worktree remove` path this PR is meant to avoid. Git documents that `worktree list --porcelain -z` must be used to correctly parse paths containing newlines. Consider switching to the `-z` (NUL-delimited) format and splitting on `\0` instead.

Force delete bypasses worktree locks

Medium Severity

The force path recursively deletes a linked worktree via the filesystem after only checking porcelain path membership. It never inspects a porcelain locked record, and the later git worktree remove still passes only a single --force. Git refuses locked worktrees unless forced twice, so a locked tree can be wiped on disk before git rejects the removal, leaving data gone and cleanup failing.

 

^{Reviewed by Cursor Bugbot for commit 4ce5dfa. Configure here.}